If you’re working on the pull request, you have to make the necessary changes. The person who is submitting the pull request can also see the comments. The pull request will be updated with your changes after you submit your review: Working on the pull request To end the review, you need to click on the review changes button and select submit review. If you click on start a review, you’ll have the chance to write more comments before sending them at once. If you click on add single comment, the comment will be made immediately. You can comment on the line of code here. When you click on the blue + button, you’ll see an editor. When you do so, you’ll see a blue + button. You can do this by hovering over the line you want to provide feedback for. If you click on the review changes button, you’ll see three options:Ī better way to review the code is to provide feedback on the line of code that requires feedback. To do so, they can click on the review changes button on the top-right-hand corner. The reviewer can comment, approve, or request for changes as they see fit. Commenting, approving, or requesting changes You can see what code is added or removed in this view. You’ll come to a page with two sets of code: Reviewing the pull requestĪs a reviewer, you’ll want to click on the files changed tab. If you don’t have write access to the repository, you won’t see a button that says merge pull request. If you want to merge the pull request, you can click on the green button and you’re done. You see this because you have write access to the repository. zellwk2 as the person who submitted the pull requestĪs the reviewer, if you scroll down to the bottom of the page, you’ll see a green button that says merge pull request.You’re going to learn how a review process will look like from both points of view:įor this lesson, I’ll use the following accounts: If they accept your pull request, your code will be merged into the branch you requested for. They’ll decide whether to accept your pull request. When you submit a pull request, a collaborator will have the right to review your pull request.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |